Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container): add box-sizing: border-box to fix size #613

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

felipefialho
Copy link
Contributor

What is being delivered?

  • Add box-sizing: border-box

What impacts?

This prevent container to not works correctly when project don't have box-sizing: border-box for all elements

Evidences

image

@felipefialho felipefialho added bug Something isn't working package/core labels Nov 8, 2024
@felipefialho felipefialho self-assigned this Nov 8, 2024
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed for 'juntossomosmais_atomium_core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-08 18:32 UTC

@felipefialho felipefialho merged commit c451d75 into main Nov 8, 2024
4 checks passed
@felipefialho felipefialho deleted the fix/container branch November 8, 2024 18:29
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants